Merged
Conversation
Previously, pods with init containers were incorrectly set to phase="Running" with Ready=True immediately upon creation, even though their containers were still in "Waiting" state with reason "Remote pod submitted". This fix changes the behavior so that pods with init containers: - Start in phase="Pending" (not "Running") - Have Ready=False (not True) - Have PodInitialized=False (correctly indicates init containers not complete) This aligns with standard Kubernetes behavior where pods should only be marked as Ready when their containers are actually ready to serve traffic. Signed-off-by: Diego Ciangottini <diego.ciangottini@pg.infn.it>
Previously, containers in pods without init containers were incorrectly marked as Ready=true immediately upon creation, even though they were still in "Waiting" state with reason "Remote pod submitted". This fix ensures that all containers start with Ready=false when created, since they are in Waiting state. The status will be updated to Ready=true later by the status polling loop once the containers are actually running. This change affects both pods with and without init containers, ensuring consistent behavior where containers are only marked Ready when they are actually ready to serve traffic, not just when they're submitted. Signed-off-by: Diego Ciangottini <diego.ciangottini@pg.infn.it>
The hasInitContainers variable was no longer needed after fixing the container Ready status to always be false at creation time. This commit removes the unused variable declaration to fix compilation. Signed-off-by: Diego Ciangottini <diego.ciangottini@pg.infn.it>
dciangot
force-pushed
the
claude/investigate-pod-ready-state-mkrRf
branch
from
c817f79 to
1adc5a8
Compare
✅ Deploy Preview for interlink-dev canceled.
|
Member
Author
|
Tested integration locally |
✅ Deploy Preview for interlink-dev canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related issue :